> On 2012-05-23 19:36:16, Dan Dumont wrote: > > trunk/features/src/main/javascript/features/core.util.onload/onload.js, > > line 55 > > <https://reviews.apache.org/r/5207/diff/1/?file=109971#file109971line55> > > > > should we be using the gadgets.logAtLevel(gadgets.log.WARNING, msg) > > here?
yes or simply gadgets.warn - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5207/#review8065 ----------------------------------------------------------- On 2012-05-23 19:26:24, Igor Belakovskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5207/ > ----------------------------------------------------------- > > (Updated 2012-05-23 19:26:24) > > > Review request for shindig and Dan Dumont. > > > Summary > ------- > > If an onload callback fails, gadgets.util.runOnLoadHandlers fails silently. > Adding a try catch warn block to handle the error, and allow other callbacks > to continue executing. > > > Diffs > ----- > > trunk/features/src/main/javascript/features/core.util.onload/onload.js > 1341960 > > Diff: https://reviews.apache.org/r/5207/diff > > > Testing > ------- > > > Thanks, > > Igor > >
