Hi Henry, I'm not recommending that we remove YUI compressor until we remove support for Java 5. If we ever do remove Java5 support, which I think would be something to look at in the 3.0 timeframe, then I think we could safely remove the YUI compressor as well. Until that time, I have no plans to touch the YUI compressor. However, if we do think the only use case for the YUI compressor is when building with Java 5, then an optimization would be to only do the YUI compression when building the Java 5 profile.
Does anyone have specific use cases where YUI is being used outside of the Java 5 builds? Thanks, -Stanton From: Henry Saputra <[email protected]> To: "[email protected]" <[email protected]>, Date: 05/31/2012 17:11 Subject: Re: Does anyone use the compress goal and and the yuicompressor-maven-plugin? Hi Dan, Stanton, Closure compiler is called in runtime whereas the YUI is used in compile time when generating the jar. Not everyone use closure complier which makes the minified JS becomes the non debug version of the JS. Until we remove support for java5 pls keep the YUI compressor as part if the build system. I believe the generated jar size wouldn't matter much. BTW Typing in iPhone sucks so sorry for any typos :P -Henry On Thursday, May 31, 2012, Stanton Sievers <[email protected]> wrote: > I talked to Dan offline about this a bit.... > > Generating the optimized files when building anything but the java5 > profile is a bit of a waste because in a "normal" build of Shindig we will > use Closure to do simple optimizations and not these optimized files. In > a Java 6 build of Shindig we end up shipping the extras and features jar > with these extra optimized code in them that never gets used. At first I > thought it might make sense to only do the compression if building the > java 5 profile... but there's nothing stopping someone from using a Java 6 > build of Shindig and injecting their own JsCompiler that may want to use > these optimized files. Does that seem like a valid use case? > > In general, how much do we care about being able to build Java 5 versions > of Shindig? I think this might be something we can phase out in 3.0 if no > one has any objections. We should also simplify the builds so that Java 7 > will work.... from what I've seen it doesn't work today. > > Thanks, > -Stanton > > > > > From: Henry Saputra <[email protected]> > To: "[email protected]" <[email protected]>, > Date: 05/31/2012 15:46 > Subject: Re: Does anyone use the compress goal and and the > yuicompressor-maven-plugin? > > > > It's used to generate opt postfixed files for the JS files when dual > resource loader is used. > > When features jar is generated the yui compressor plugin is called to > generate minified version of the JS. > > On Thursday, May 31, 2012, Dan Dumont <[email protected]> wrote: >> What are those used for? Closure works on the raw source I thought, > and >> it's enabled by default now. >> >> >> >> From: Henry Saputra <[email protected]> >> To: "[email protected]" <[email protected]>, >> Date: 05/31/2012 12:00 PM >> Subject: Re: Does anyone use the compress goal and and the >> yuicompressor-maven-plugin? >> >> >> >> I thought that's used to generate the .opt files for the JavaScript? >> >> - Henry >> >> On Thursday, May 31, 2012, Dan Dumont <[email protected]> wrote: >>> If not, can we remove it from the features and extras pom.xml? >> >> > >
