Doug here is the review and the JIRA. http://codereview.appspot.com/6305079/ https://issues.apache.org/jira/browse/SHINDIG-1796
-Ryan From: Ryan J Baxter/Westford/IBM To: [email protected], Date: 06/09/2012 07:36 PM Subject: Re: GroupId Doug I hope to get a chance to look at a possible solution tomorrow. -Ryan From: daviesd <[email protected]> To: <[email protected]>, Date: 06/09/2012 12:49 AM Subject: Re: GroupId I had not opened one. I was waiting for Ryan's response to my follow-up. doug On 6/8/12 9:16 PM, "Henry Saputra" <[email protected]> wrote: > Hi Doug, do you have a JIRA opened for this issue? > > - Henry > > On Wed, Jun 6, 2012 at 9:52 AM, daviesd <[email protected]> wrote: >> Some changes were made to GroupId between 2.5-beta1 and 2.5-beta2 that are >> affecting me. >> >> GroupId.Type changed from this >> >> ? all, friends, self, deleted, groupId; >> >> To this >> >> ? objectId(0), self(1), friends(2), all(3); >> >> We had extended AppDataService to support a groupId of @institution >> (something that is relevant in our domain) >> >> ? ? ? ? ? ?osapi.appdata.get({ >> ? ? ? ? ? ? ? ?userId: '@me', >> ? ? ? ? ? ? ? ?groupId : '@institution', >> ? ? ? ? ? ? ? ?appId : '@app'} ) >> >> However, I have concerns as to how this will work now, because I¹m fighting >> through a unit test that does this >> >> ? ?groupId = GroupId.fromJson("@institution") >> >> And it¹s throwing a IllegalArgumentException. >> >> Can some one point me in the right direction as to how I¹m suppose to handle >> something like this? >> >> Thanks, >> doug >> >
