----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5335/#review8329 -----------------------------------------------------------
Looks good to me from a code perspective. I might need to play around with this change to wrap my head around it. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js <https://reviews.apache.org/r/5335/#comment17947> Should be "container's" http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js <https://reviews.apache.org/r/5335/#comment17948> Param should really be changed to "tokenOrWait" - Stanton Sievers On June 17, 2012, 2:02 a.m., Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5335/ > ----------------------------------------------------------- > > (Updated June 17, 2012, 2:02 a.m.) > > > Review request for shindig and Stanton Sievers. > > > Description > ------- > > Allow fatal errors to be reported to waiting callbacks. > Allow callbacks to indicate they aren't pushy, and don't want to trigger an > immediate refresh. > Allow containers to ask the refresh mechanism to call back again in x seconds > when there was an error. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js > 1349992 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js > 1349992 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js > 1349992 > > Diff: https://reviews.apache.org/r/5335/diff/ > > > Testing > ------- > > > Thanks, > > Dan Dumont > >
