> On June 26, 2012, 7:15 p.m., Dan Dumont wrote: > > Ship It!
Already committed :) Will close. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2358/#review8629 ----------------------------------------------------------- On Oct. 12, 2011, 3:28 p.m., Michael Beaver wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2358/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2011, 3:28 p.m.) > > > Review request for shindig. > > > Description > ------- > > The Media.xml gadget directly calls dojo.addOnLoad(init) in order to > workaround an issue with tundra.css instead of wrapping it in a call to > gadgets.util.registerOnLoadHandler(). This results in multiple instances of > the gadget not being supported when rendering in IE8. Removing the direct > call to dojo.addOnLoad and wrapping it in gadgets.util.registerOnLoadHandler > fixes this issue, and the tundra.css issue no longer appears. > > > This addresses bug SHINDIG-1640. > https://issues.apache.org/jira/browse/SHINDIG-1640 > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/media/Media.xml 1178561 > > Diff: https://reviews.apache.org/r/2358/diff/ > > > Testing > ------- > > > Thanks, > > Michael Beaver > >
