----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/#review8753 -----------------------------------------------------------
Ship it! Committed revision 1355476. Please close this review. - Stanton Sievers On June 27, 2012, 10:44 p.m., Matthew Reiter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5589/ > ----------------------------------------------------------- > > (Updated June 27, 2012, 10:44 p.m.) > > > Review request for shindig. > > > Description > ------- > > Code review for my proposed solution to "makeRequest fails on IE when ActiveX > is disabled". > > > This addresses bug SHINDIG-1808. > https://issues.apache.org/jira/browse/SHINDIG-1808 > > > Diffs > ----- > > /trunk/features/src/main/javascript/features/core.io/io.js 1354070 > /trunk/features/src/test/javascript/features/core.io/iotest.js 1354070 > > Diff: https://reviews.apache.org/r/5589/diff/ > > > Testing > ------- > > Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with > ActiveX disabled and IE 9 with ActiveX enabled. > > > Thanks, > > Matthew Reiter > >
