> On July 21, 2012, 5:42 p.m., Stanton Sievers wrote: > > trunk/features/src/main/javascript/features/core.util.base/base.js, line 84 > > <https://reviews.apache.org/r/6070/diff/1/?file=125824#file125824line84> > > > > This will catch all IE browsers, right? Do we not want to poll in IE8 > > or newer? Is this check valid if ActiveX is disabled in the browser?
Yes. No. No (looks like you can disabled both actives and xmlhttprequest in IE) :( I will update the patch to add check for ie7 or lower. Thanks for catching the error - Henry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6070/#review9332 ----------------------------------------------------------- On July 21, 2012, 12:16 a.m., Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6070/ > ----------------------------------------------------------- > > (Updated July 21, 2012, 12:16 a.m.) > > > Review request for shindig. > > > Description > ------- > > Fix memory leak in IE7 for Ajax call in core.io feature using polling > technique used in YUI2 connection manager. > > The leak happen due to circular link that ajax onreadystatechange handler > that has link to the main xhr object. IE garbage collector hates that. > > > Diffs > ----- > > trunk/config/container.js 1363863 > trunk/features/src/main/javascript/features/core.io/io.js 1363863 > trunk/features/src/main/javascript/features/core.util.base/base.js 1363863 > > Diff: https://reviews.apache.org/r/6070/diff/ > > > Testing > ------- > > Pass unit tests and in common container. > > > Thanks, > > Henry Saputra > >
