----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5677/ -----------------------------------------------------------
(Updated July 21, 2012, 11:50 p.m.) Review request for shindig, Paul Lindner, Henry Saputra, johnfargo, Ryan Baxter, and Stanton Sievers. Description ------- We've noticed over here that the request url for a page of feature code javascript is included in the actual output. This means that altering the url slightly will result in a cache-miss as the content changes, even if you append bogus features. Obviously this is not ideal. I don't think that the config override mechanism that uses the request url is exactly necessary... or even used! I've tried my best to adapt the config override mechanism and maintain the previous functionality. It's mostly the same with a small caveat. I would really appreciate a review from John H, as I think he was the original contributor of the override stuff. Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1356296 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/init.js 1356296 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.config.base/config.js 1356296 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core/config-test.js 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BasicSecurityTokenCodec.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/ShindigAuthConfigContributor.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJslInfoVariableProcessor.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJslLoadedVariableProcessor.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddOnloadFunctionProcessor.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsContent.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsResponseBuilder.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientCredentialsGrantTypeHandler.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/CodeAuthorizationResponseHandler.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateLibraryFactory.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/Test.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/CompileResult.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/AddJslInfoVariableProcessorTest.java 1356296 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/AddJslLoadedVariableProcessorTest.java 1356296 Diff: https://reviews.apache.org/r/5677/diff/ Testing ------- Js tests updated and passing. Java test updated and passing. Thanks, Dan Dumont
