----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6140/#review9466 -----------------------------------------------------------
trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java <https://reviews.apache.org/r/6140/#comment20279> This same pattern seems to be duplicated all over this case statement. Shouldn't we just define a helper method that takes table and userId arguments? I realize it is just example code for the JSON DB, but why not make it simpler? - Matt Franklin On July 25, 2012, 6:02 p.m., Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6140/ > ----------------------------------------------------------- > > (Updated July 25, 2012, 6:02 p.m.) > > > Review request for shindig. > > > Description > ------- > > See https://issues.apache.org/jira/browse/SHINDIG-1821 for details > > > This addresses bug SHINDIG-1821. > https://issues.apache.org/jira/browse/SHINDIG-1821 > > > Diffs > ----- > > trunk/content/sampledata/canonicaldb.json 1364039 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java > 1364039 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java > 1364039 > > Diff: https://reviews.apache.org/r/6140/diff/ > > > Testing > ------- > > > Thanks, > > Henry Saputra > >
