----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6208/ -----------------------------------------------------------
Review request for shindig. Description ------- Spaces proposal patch for shindig: http://docs.opensocial.org/display/OSD/Space+Proposal the changes are isolated, it should not break other things because it is mainly the definition of new REST/RPC/osapi endpoints and the Space/App model plus handling of IRI Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/sampledata/canonicaldb.json 1367105 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/osapi/peoplehelpers.js 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/AppDb.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/SpaceDb.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/resources/META-INF/orm.xml 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/appsTest.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/osapiTest.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/spacesTest.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/AppImpl.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/SpaceImpl.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/App.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Space.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AppHandler.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/SocialRequestItem.java 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/SpaceHandler.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppService.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/Resource.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/ResourceId.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/SpaceService.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/SampleModule.java 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppHandlerTest.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/SocialRequestItemTest.java 1367105 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/SpaceHandlerTest.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/ResourceIdTest.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/ResourceTest.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1367105 Diff: https://reviews.apache.org/r/6208/diff/ Testing ------- with the patch, the shindig tests pass without problems Thanks, Evgeny Bogdanov
