----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6198/ -----------------------------------------------------------
(Updated Aug. 5, 2012, 1:37 a.m.) Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. Changes ------- Add a new method getGadgetUri in GadgetSpecFactory interface, so Processor can use this method to get the gadget uri instead of get the uri from context directly. Description ------- The gadgets/ifr endpoint will fetch the gadget xml first and then do the white list check. It is consuming resources to fetch content when the gadget is not allowed to render according to the gadget admin. The proposed fix is to move the white list check ahead of processing the gadget xml. If the gadget is not allowed to show, an error message will be returned before doing the content fetching. This addresses bug shindig-1830. https://issues.apache.org/jira/browse/shindig-1830 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java 1368808 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetSpecFactory.java 1368808 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1368808 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/FakeGadgetSpecFactory.java 1368808 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/MockUtils.java 1368808 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/process/ProcessorTest.java 1368808 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/BaseRewriterTestCase.java 1368808 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/RewriterTestBase.java 1368808 Diff: https://reviews.apache.org/r/6198/diff/ Testing ------- Done. Thanks, Marshall Shi