----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6563/ -----------------------------------------------------------
(Updated Aug. 15, 2012, 2:26 a.m.) Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. Description ------- Recent Microsoft updates patched some code that was used by the RPC layer (from the Shindig project) to do messaging on Internet Explorer 6 and 7. OpenAjax Hub 2.0.7 fixes this by disabling the broken transport layer (NIX) and falling back to the fragment identifier transport (IFPC). Some further details can be found at [1] and [2]. [1] http://openajax.org/pipermail/interop/2011q2/001261.html [2] http://openajax.org/pipermail/interop/2011q2/001262.html This patch has compared the OAH code in Shindig with the OAH 2.0.7, merged the incoming changes of 2.0.7 into Shindig. Due to some issues with changing directory name from "org.openajax.hub-2.0.5" to "org.openajax.hub-2.0.7", a few more clean steps need to be done after the patch delivered into Shindig trunk: 1. rename: (/shindig-project/extras/src/main/javascript/features-extras/) "org.openajax.hub-2.0.5" to "org.openajax.hub-2.0.7" 2. /shindig-project/features/src/main/javascript/features/container.site.gadget/gadget_holder.js, change the documentation from "@see osapi.container.GadgetHolder.prototype.doOaaIframeHtml_ and org.openajax.hub-2.0.5/iframe.js:createIframe()" to "@see osapi.container.GadgetHolder.prototype.doOaaIframeHtml_ and org.openajax.hub-2.0.7/iframe.js:createIframe()". This addresses bug shindig-1836. https://issues.apache.org/jira/browse/shindig-1836 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/OpenAjax-mashup.js 1368808 http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/feature.xml 1368808 http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1368808 http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/pubsub-2/feature.xml 1368808 Diff: https://reviews.apache.org/r/6563/diff/ Testing ------- Done. Thanks, Marshall Shi
