----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6945/#review11257 -----------------------------------------------------------
Ship it! +1 - Henry Saputra On Sept. 10, 2012, 5:48 p.m., Robert O'Neill wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6945/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2012, 5:48 p.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > > > Description > ------- > > Every rpc register within a gadget should check the `from` and make sure that > it's correct to process the call. > > > Diffs > ----- > > trunk/features/src/main/javascript/features/actions/actions.js 1378988 > trunk/features/src/main/javascript/features/auth-refresh/auth-refresh.js > 1378988 > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js > 1378988 > > trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js > 1378988 > > trunk/features/src/main/javascript/features/opensocial-jsonrpc/jsonrpccontainer.js > 1378988 > trunk/features/src/main/javascript/features/pubsub/pubsub.js 1378988 > trunk/features/src/main/javascript/features/selection/selection.js 1378988 > > Diff: https://reviews.apache.org/r/6945/diff/ > > > Testing > ------- > > > Thanks, > > Robert O'Neill > >
