----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6561/ -----------------------------------------------------------
(Updated Sept. 11, 2012, 1:44 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich
Thompson.
Description
-------
The gadget iframe should follow certain format to pass the accessibility test,
rough format is:
<iframe title="[gadget_title]" >
<html lang="[lang]" xml:lang="[lang]">
<body></body>
</html>
</iframe>
This addresses bug shindig-1835.
https://issues.apache.org/jira/browse/shindig-1835
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
1374903
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js
1373213
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.url/url_holder.js
1373213
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site.js
1373213
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site_holder.js
1373213
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_holder_test.js
1373213
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js
1373213
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java
1382185
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java
1373213
Diff: https://reviews.apache.org/r/6561/diff/
Testing
-------
Done.
Thanks,
Marshall Shi
