----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7122/#review11612 -----------------------------------------------------------
Ship it! Ship It! - Dan Dumont On Sept. 15, 2012, 4:58 p.m., Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7122/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2012, 4:58 p.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > > > Description > ------- > > Disable thread in the closure compiler code since Shindig manage the thread > in the ClosureJSCompiler class via ExecuterService framework. > Otherwise internally the closure compiler create another thread then execute > the compile in that new thread instead > > But we need to create the thread big enough stack to handle the compilation. > Copy the max stack size from the closure compiler code. > > > Diffs > ----- > > > trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java > 1384587 > > Diff: https://reviews.apache.org/r/7122/diff/ > > > Testing > ------- > > Run smoke test with common container with debug sets to false to run the > closure js compiler. > > > Thanks, > > Henry Saputra > >
