----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7089/#review11615 -----------------------------------------------------------
Ship it! Ship It! - Ryan Baxter On Sept. 14, 2012, 2:09 p.m., Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7089/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2012, 2:09 p.m.) > > > Review request for shindig and Ryan Baxter. > > > Description > ------- > > Redirect uri was not being set for gadgets.io completion. > > > This addresses bug SHINDIG-1869. > https://issues.apache.org/jira/browse/SHINDIG-1869 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/container_oauthpopup.js > 1384338 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/feature.xml > 1384338 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js > 1384338 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/oauthpopup/oauthpopup-test.js > 1384338 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java > 1384338 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuthCallbackServlet.java > 1384338 > > Diff: https://reviews.apache.org/r/7089/diff/ > > > Testing > ------- > > All tests pass. Tested an oauth 1.0a gadget in the sample container. > > > Thanks, > > Dan Dumont > >