> On Sept. 19, 2012, 1:50 p.m., Dan Dumont wrote: > > Nice catch! > > > > What do others think would be best? Change this to use the fragment as a > > blob, or enhance the shindig.uri js class to encode multiple params in the > > fragment like the java side does?
I would +1 to change it to encode multiple params to the URL fragment to be consistent with rendering flow. - Henry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7166/#review11690 ----------------------------------------------------------- On Sept. 19, 2012, 1:36 p.m., Matt Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7166/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2012, 1:36 p.m.) > > > Review request for shindig. > > > Description > ------- > > Change TokenRequestData to use the whole URL fragment rather than a fragment > parameter, as this is what is sent to the container. > > > This addresses bug SHINDIG-1873. > https://issues.apache.org/jira/browse/SHINDIG-1873 > > > Diffs > ----- > > > tags/shindig-project-2.5.0-beta4/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java > 1387492 > > Diff: https://reviews.apache.org/r/7166/diff/ > > > Testing > ------- > > > Thanks, > > Matt Jones > >
