----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8266/#review13947 -----------------------------------------------------------
Add the JIRA to the Bug field on the review and remove the extra whitespace. Are there unit tests for these classses that need to be updated at all? - Ryan Baxter On Nov. 29, 2012, 11:17 a.m., Jan Willem Janssen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8266/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2012, 11:17 a.m.) > > > Review request for shindig, Henry Saputra and Ryan Baxter. > > > Description > ------- > > Patch for the Social API regarding SHINDIG-1878. > > > Diffs > ----- > > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/AddressImpl.java > 1415078 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/NameImpl.java > 1415078 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/OrganizationImpl.java > 1415078 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/PersonImpl.java > 1415078 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Address.java > 1415078 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Name.java > 1415078 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Organization.java > 1415078 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Person.java > 1415078 > > Diff: https://reviews.apache.org/r/8266/diff/ > > > Testing > ------- > > > Thanks, > > Jan Willem Janssen > >
