----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9369/#review16352 -----------------------------------------------------------
Ship it! Ship It! - Stanton Sievers On Feb. 8, 2013, 12:07 a.m., Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9369/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2013, 12:07 a.m.) > > > Review request for shindig, Dan Dumont and Stanton Sievers. > > > Description > ------- > > Right now if you provide a buffering element to a gadget site it switched the > buffering site as soon as the holder's render method is called. You will get > a better user experience if you wait until the gadget DOM has finished > loading to make the switch. > > > This addresses bug SHINDIG-1902. > https://issues.apache.org/jira/browse/SHINDIG-1902 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js > 1436363 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js > 1442677 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js > 1436363 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js > 1436363 > > Diff: https://reviews.apache.org/r/9369/diff/ > > > Testing > ------- > > Added new unit tests > > > Thanks, > > Ryan Baxter > >
