> On Feb. 12, 2013, 1:36 a.m., Ryan Baxter wrote: > > Can you add a unit test which tests this case?
Have added test case for modification, please check it. - Jiaqing ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7497/#review16454 ----------------------------------------------------------- On Feb. 21, 2013, 11:51 a.m., Jiaqing Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7497/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2013, 11:51 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > > > Description > ------- > > This patch is used to fix bug SHINDIG-1877. > It will do a enhancement for FeatureRegistry to detect feature dependency > loop problem when it tries to complete dependency node graph for loaded > feature node. > > > This addresses bug SHINDIG-1877. > https://issues.apache.org/jira/browse/SHINDIG-1877 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java > 1448596 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/features/FeatureRegistryTest.java > 1448596 > > Diff: https://reviews.apache.org/r/7497/diff/ > > > Testing > ------- > > > Thanks, > > Jiaqing Guo > >
