> On Feb. 21, 2013, 5:44 a.m., Marshall Shi wrote: > > Ryan, test cases updated, could you take another look? > > Ryan Baxter wrote: > Looks like you need to do an svn update and recreate the patch, I am > having problems applying it.
Not sure what I was doing earlier, Committed revision 1448873 - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9308/#review16834 ----------------------------------------------------------- On Feb. 18, 2013, 3:05 a.m., Marshall Shi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9308/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2013, 3:05 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Rich Thompson. > > > Description > ------- > > One more fix for my previous patch of gadget iframe accessibility fixes. > https://reviews.apache.org/r/6561/ > > > This addresses bug shindig-1835. > https://issues.apache.org/jira/browse/shindig-1835 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js > 1446375 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js > 1446375 > > Diff: https://reviews.apache.org/r/9308/diff/ > > > Testing > ------- > > > Thanks, > > Marshall Shi > >
