----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9536/#review16935 -----------------------------------------------------------
Ship it! Ship It! - Stanton Sievers On Feb. 22, 2013, 12:40 p.m., Marshall Shi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9536/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2013, 12:40 p.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Rich Thompson. > > > Description > ------- > > BasicOAuth2Request allowed domain checks are case sensitive and shouldn't be. > > > This addresses bug SHINDIG-1907. > https://issues.apache.org/jira/browse/SHINDIG-1907 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java > 1448873 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Utils.java > 1406188 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/CodeAuthorizationResponseHandler.java > 1406188 > > Diff: https://reviews.apache.org/r/9536/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Marshall Shi > >
