----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9574/#review17044 -----------------------------------------------------------
Ship it! Ship It! - Stanton Sievers On Feb. 25, 2013, 2:53 p.m., Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9574/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 2:53 p.m.) > > > Review request for shindig, Paul Lindner and Stanton Sievers. > > > Description > ------- > > We have upgraded the dependencies for Shindig and they no longer support Java > 1.5. We voted and no one voiced any concerns about dropping Java 1.5 support. > We need to update the POM files to remove the Java 1.5 and Java 1.6 profiles. > > Note: The deletion in this patch of JsCompilerModule.java, > ClosureJsCompiler.java, and CompileResult.java are actually moves of those > files to the correct directories in src/main/java. Looks like SVN patches > don't capture that very well. Also I will delete the java15 and java16 > directories after I check in these changes and confirm there are no problems. > > > This addresses bug SHINDIG-1908. > https://issues.apache.org/jira/browse/SHINDIG-1908 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/pom.xml 1449564 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/js/JsCompilerModule.java > 1449564 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java > 1449564 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/CompileResult.java > 1449564 > http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1449564 > > Diff: https://reviews.apache.org/r/9574/diff/ > > > Testing > ------- > > > Thanks, > > Ryan Baxter > >
