----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7497/#review17096 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/features/FeatureRegistryTest.java <https://reviews.apache.org/r/7497/#comment36180> Instead of just doing nothing you can expect that the exception will be thrown. This is cleaner and what I was suggesting in my previous comment as well. - Ryan Baxter On Feb. 26, 2013, 9:50 a.m., Jiaqing Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7497/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2013, 9:50 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > > > Description > ------- > > This patch is used to fix bug SHINDIG-1877. > It will do a enhancement for FeatureRegistry to detect feature dependency > loop problem when it tries to complete dependency node graph for loaded > feature node. > > > This addresses bug SHINDIG-1877. > https://issues.apache.org/jira/browse/SHINDIG-1877 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java > 1448596 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/features/FeatureRegistryTest.java > 1448596 > > Diff: https://reviews.apache.org/r/7497/diff/ > > > Testing > ------- > > > Thanks, > > Jiaqing Guo > >
