Review Request: value of oauth_expires_in returned from server is 0 should be respected as oauth expire unknown

[Zhi Hong Yang]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9747/
-----------------------------------------------------------

Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich 
Thompson.


Description
-------

In OauthRuest.java:
    accessorInfo.setTokenExpireMillis(ACCESS_TOKEN_EXPIRE_UNKNOWN);
    if (OAuthUtil.getParameter(reply, OAuthConstants.OAUTH_EXPIRES_IN) != null) 
{
      try {
        int expireSecs = Integer.parseInt(OAuthUtil.getParameter(reply,
            OAuthConstants.OAUTH_EXPIRES_IN));
        if (expireSecs > 0) {
          long expireMillis = fetcherConfig.getClock().currentTimeMillis() + 
expireSecs * 1000L;
          accessorInfo.setTokenExpireMillis(expireMillis);
        }  

if expireSecs is 0, the TokenExpireMillis value of accessInfo should be 
remained as ACCESS_TOKEN_EXPIRE_UNKNOWN.


Diffs
-----

  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
 1452675 

Diff: https://reviews.apache.org/r/9747/diff/


Testing
-------


Thanks,

Zhi Hong Yang