----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9324/ -----------------------------------------------------------
(Updated March 6, 2013, 6:32 a.m.) Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson. Description ------- in shindig.properties, the scheme is hardcoded in following setting: shindig.signing.global-callback-url=http://%authority%%contextRoot%/gadgets/oauthcallback shindig.oauth2.global-redirect-uri=http://%authority%%contextRoot%/gadgets/oauth2callback should be fixed as : shindig.signing.global-callback-url=%scheme%://%authority%%contextRoot%/gadgets/oauthcallback shindig.oauth2.global-redirect-uri=%scheme%://%authority%%contextRoot%/gadgets/oauth2callback Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1453162 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java 1453162 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Accessor.java 1453162 http://svn.apache.org/repos/asf/shindig/trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/src/main/resources/shindig.properties 1453162 Diff: https://reviews.apache.org/r/9324/diff/ Testing (updated) ------- No new test cases is needed. Thanks, Zhi Hong Yang
