----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9773/#review17497 -----------------------------------------------------------
First, thanks for the patch! This looks tremendous! I haven't had a chance to look at this from a functional perspective yet, but there are a few things I've noticed that will need to be changed before we can accept this patch. Your entire package structure is "de.hofuniversity.iisys.graphbackend". This really needs to be "org.apache.shindig.graphbackend" (or the like) if we want to include this in Shindig. It might be best if we ignore this for now until we have a deeper functional review. A lot of this source also does not comform to the Shindig coding conventions. Checkstyle is built into the Shindig builds if you want to see the complaints. Eclipse formatting and cleanup tools can likely take care of a lot of these. RAT also found that you are missing Apache licenses on these files: java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntryTest.java java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppDataTest.java java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroupTest.java java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollectionTest.java java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageTest.java java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPersonTest.java I'll start reviewing the rest of the code this week and will try to provide you more feedback. Do you have a sample web.xml that is using the neo4j implementation? I don't see that you've changed any existing guice modules, so I assume I need to point to a guice module you created in my web.xml. Is that the case? Thanks! - Stanton Sievers On March 6, 2013, 9:21 a.m., René Peinl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9773/ > ----------------------------------------------------------- > > (Updated March 6, 2013, 9:21 a.m.) > > > Review request for shindig. > > > Description > ------- > > Review for Shindig-1911 > Alternative database backend based on graph database neo4j > Any comments welcome. We are committed to further improve this. > > > This addresses bug Shindig-1911. > https://issues.apache.org/jira/browse/Shindig-1911 > > > Diffs > ----- > > /trunk/java/neo4j-backend/pom.xml PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/Constants.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphAPIModule.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GraphConfig.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/GuiceModule.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/INeo4jConnector.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jConnector.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jHAConnector.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRelTypes.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/db/neo4j/Neo4jRestConnector.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrgPersonImpl.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/ExtOrganizationImpl.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrgPerson.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/IExtOrganization.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityEntry.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherActivityObject.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherAttributesMessage.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherListFieldList.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessage.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherMessageCollection.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/cypher/CypherPerson.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ADataTransferObject.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AccountDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityEntryDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/ActivityObjectDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/AddressDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/DTOHelper.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/GroupDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaItemDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MediaLinkDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageCollectionDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/MessageDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/OrganizationDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/dto/PersonDTO.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAccount.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivity.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntry.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityObject.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAddress.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppData.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroup.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphListFieldList.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaItem.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMediaLink.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessage.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollection.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphOrganization.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPerson.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAccount.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringAddress.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringApplication.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringOrganization.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/model/spring/SpringPerson.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/ExtPersonHandler.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandler.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAlbumSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMediaItemSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IExtPersonService.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IFriendService.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/IGraphService.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherActivityStreamSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGraphSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherGroupSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherMessageSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/CypherPersonSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherActivityStreamSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGraphSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherGroupSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherMessageSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/RestCypherPersonSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/cypher/dsl/RestCypherDSLPersonSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinGraphSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinMessageSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/gremlin/GremlinPersonSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/PersonRepository.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/spring/SpringPersonSPI.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectService.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/ApplicationService.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/service/IDManager.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/BatchParser.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataGenerator.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/testdata/DataParser.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeFilter.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/NodeSorter.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/main/java/de/hofuniversity/iisys/graphbackend/util/PersonFilter.java > PRE-CREATION > /trunk/java/neo4j-backend/src/main/resources/graph-backend.properties > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphActivityEntryTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphAppDataTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphGroupTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageCollectionTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphMessageTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/model/graph/GraphPersonTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/service/UserHandlerTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivitySPITest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphActivityStreamSPITest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphAppDataSPITest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphFriendSPITest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphGroupSPITest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphMessageSPITest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphPersonSPITest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/opensocial/spi/GraphSPITest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ActivityObjectServiceTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/ApplicationServiceTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/service/IDManagerTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeFilterTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/NodeSorterTest.java > PRE-CREATION > > /trunk/java/neo4j-backend/src/test/java/de/hofuniversity/iisys/graphbackend/util/PersonFilterTest.java > PRE-CREATION > /trunk/pom.xml 1452786 > > Diff: https://reviews.apache.org/r/9773/diff/ > > > Testing > ------- > > > Thanks, > > René Peinl > >
