----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9891/#review18152 -----------------------------------------------------------
Ship it! nice :) - Dan Dumont On March 13, 2013, 1:44 a.m., Paul Lindner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9891/ > ----------------------------------------------------------- > > (Updated March 13, 2013, 1:44 a.m.) > > > Review request for shindig. > > > Description > ------- > > Replace FutureUtil and ImmediateFuture with Futures Guava implementation > > > Diffs > ----- > > > /trunk/java/common/src/main/java/org/apache/shindig/common/util/FutureUtil.java > 1455586 > > /trunk/java/common/src/main/java/org/apache/shindig/common/util/ImmediateFuture.java > 1455586 > > /trunk/java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java > 1455586 > > /trunk/java/common/src/test/java/org/apache/shindig/common/util/FutureUtilTest.java > 1455586 > > /trunk/java/common/src/test/java/org/apache/shindig/common/util/ImmediateFutureTest.java > 1455586 > > /trunk/java/common/src/test/java/org/apache/shindig/protocol/TestHandler.java > 1455586 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java > 1455586 > > /trunk/java/sample-container/src/main/java/org/apache/shindig/sample/container/SampleContainerHandler.java > 1455586 > > /trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/ActivityServiceDb.java > 1455586 > > /trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/AppDataServiceDb.java > 1455586 > > /trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java > 1455586 > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java > 1455586 > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java > 1455586 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/ActivityHandlerTest.java > 1455586 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/ActivityStreamHandlerTest.java > 1455586 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java > 1455586 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/MessageHandlerTest.java > 1455586 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java > 1455586 > > Diff: https://reviews.apache.org/r/9891/diff/ > > > Testing > ------- > > Basic smoke tests. > > > Thanks, > > Paul Lindner > >
