----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11024/#review20851 -----------------------------------------------------------
Great that patch worked but I see another problem. Since you updated the AppDataService interface you need to also update AppDataServiceDb or else you get compile errors when you build shindig-samples. Henry should be removing this project soon so if it is going to take you more than a minute to fix it I would just wait until that happens. - Ryan Baxter On May 21, 2013, 4:12 p.m., Venkat Mahadevan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11024/ > ----------------------------------------------------------- > > (Updated May 21, 2013, 4:12 p.m.) > > > Review request for shindig. > > > Description > ------- > > Currently the AppData is handling only a Map<String, String>. Need the > ability to handle values other than String, something like Map<String, > Object> so that we can have, for eg., boolean value as well. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AppDataHandler.java > 1484816 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppDataService.java > 1484816 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java > 1484816 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java > 1484816 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java > 1484816 > > Diff: https://reviews.apache.org/r/11024/diff/ > > > Testing > ------- > > > Thanks, > > Venkat Mahadevan > >
