----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11584/#review21477 -----------------------------------------------------------
If there are no other concerns, I'll commit this in ~24 hours. Thanks. - Stanton Sievers On June 3, 2013, 8:29 p.m., Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11584/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 8:29 p.m.) > > > Review request for shindig. > > > Description > ------- > > org.apache.shindig.gadgets.DefaultGadgetSpecFactory and > org.apache.shindig.gadgets.DefaultMessageBundleFactory utilize a property in > shindig.properties (shindig.cache.xml.refreshInterval) to force the > RequestPipeline/Fetcher layer to cache specs and message bundles for a set > amount of time, regardless of the cache headers on the response. This also > forces the cache ttl in the case that the response is an error instead of > using the "shindig.cache.http.negativeCacheTtl" value in shindig.properties, > which defaults to one minute. > > I'd rather we always use the negativeCacheTtl in this case and ignore the > forced cache ttl. > > This patch addresses that. Do others think this is a good idea? > > > This addresses bug SHINDIG-1920. > https://issues.apache.org/jira/browse/SHINDIG-1920 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java > 1485016 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java > 1485016 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java > 1485016 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/HttpResponseTest.java > 1485016 > > Diff: https://reviews.apache.org/r/11584/diff/ > > > Testing > ------- > > I functionally tested this and also wrote a unit test. All existing unit > tests continue to pass. > > > Thanks, > > Stanton Sievers > >
