On Wed, Jul 17, 2013 at 6:20 AM, Charl van Niekerk <c.vanniek...@utwente.nl> wrote: > On Tue, Jul 09, 2013 at 12:19:13PM -0400, Ryan Baxter wrote: >> Sounds like a good enough spot to me. > > I added the following classes: > > org.apache.shindig.gadgets.servlet.GadgetSettingsServlet > org.apache.shindig.gadgets.render.GadgetSettings > org.apache.shindig.gadgets.GadgetSettingsException > >> I would suggest you make your changes and then post a patch to >> reviews.apache.org so we can get a better feel for you changes. There >> is some good documentation on the Community Overiview [1] page on the >> Shindig site that might help you. If you can't find an answer there >> don't be afraid to shoot the dev list an email. > > Thanks! I attached the patch to an existing issue: > > https://issues.apache.org/jira/browse/SHINDIG-1188 > > I posted a review request: > > https://reviews.apache.org/r/12647/
Great I added some comments there. > > Unfortunately I failed applying the Shindig code conventions in Eclipse (not > too familiar with the IDE). > > There is one further thing needed. The reference to gmodules.com needs to be > changed in: > > http://svn.apache.org/repos/asf/shindig/branches/2.0.x/features/src/main/javascript/features/shindig.container/shindig-container.js > > For testing I hard coded it temporarily on my local checkout but the base URL > needs to be read from some configuration. Items from container.js (container configuration) can be access from features. Take a look at the core.config feature and the other features that use it. > > I'm not sure how to do this so I have not included it in the patch. > > Please let me know if there is anything else I need to do from my side. > > Best Regards, > Charl > > -- > Charl van Niekerk > ICT Service Centre > University of Twente
