Henry, this is kind of a hard situation to unit test. We have some unit tests the head down this code path but it is the browser calling the onload listeners on the iframe.
On Sun, Jul 21, 2013 at 9:40 PM, Henry Saputra <henry.sapu...@gmail.com> wrote: > Does Shindig have unit test to catch this issue? > > > - Henry > > > On Sat, Jul 20, 2013 at 7:08 PM, Ryan Baxter <rbaxte...@apache.org> wrote: > >> I am going to have to vote -1 :( >> >> Looks like there is a bug in the common container code when we render >> pubsub gadgets but only in Chrome and Safari, FireFox seems to work >> OK. The same bug was in beta6 but not in beta5. >> >> Looks like the iFrame for the gadget is not being added to the page >> properly in trunk, then a few lines later we try to get the iFrame >> from the DOM by its ID but it is not there. I have not been able to >> narrow down the change that caused the problem yet. If anyone has any >> ideas which change may of caused this please let me know. >> >> I will start the process of reverting the release once I have a better >> idea of what is going on. >> >> On Tue, Jul 16, 2013 at 6:47 PM, Stanton Sievers <ssiev...@apache.org> >> wrote: >> > +1 >> > >> > I verified the signatures and md5 checksums for all artifacts. I also >> > sanity checked the sample commoncontainer and all gadgets rendered as >> > expected. >> > >> > Thanks Ryan! >> > >> > >> > On Tue, Jul 16, 2013 at 1:17 PM, Ryan Baxter <rbaxte...@apache.org> >> wrote: >> > >> >> NP Henry. There is a tag [1] for the release. >> >> >> >> [1] >> https://svn.apache.org/repos/asf/shindig/tags/shindig-project-2.5.0/ >> >> >> >> On Tue, Jul 16, 2013 at 1:13 PM, Henry Saputra <henry.sapu...@gmail.com >> > >> >> wrote: >> >> > HI Ryan, thanks for starting the release process =) >> >> > >> >> > Did you create svn branch to create the release artifacts? >> >> > >> >> > - Henry >> >> > >> >> > >> >> > On Mon, Jul 15, 2013 at 6:25 PM, Ryan Baxter <rbaxte...@apache.org> >> >> wrote: >> >> > >> >> >> Hi, >> >> >> >> >> >> We solved 296 issues: >> >> >> >> >> >> >> >> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SHINDIG%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20in%20(%222.5.0%22%2C%20%222.5.0-beta6%22%2C%20%222.5.0-beta5%22%2C%20%222.5.0-beta4%22%2C%20%222.5.0-beta3%22%2C%20%222.5.0-beta2%22%2C%20%222.5.0-beta1%22)%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC >> >> >> >> >> >> Staging repo: >> >> >> >> >> >> >> >> >> https://repository.apache.org/content/repositories/orgapacheshindig-148/org/apache/shindig/ >> >> >> >> >> >> Web site: >> >> >> http://shindig.apache.org/ >> >> >> >> >> >> Vote open for 72 hours. >> >> >> >> >> >> [ ] +1 >> >> >> [ ] +0 >> >> >> [ ] -1 >> >> >> >> >> >>
