----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14629/#review26973 -----------------------------------------------------------
Ship it! Ship It! - Ryan Baxter On Oct. 14, 2013, 3:04 p.m., Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14629/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2013, 3:04 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1938 > https://issues.apache.org/jira/browse/SHINDIG-1938 > > > Repository: shindig > > > Description > ------- > > org.apache.shindig.protocol.DataCollection currently handles only > Map<String,String> but it should handle Map<String,Object> because of the App > Data API updates in SHINDIG-1916 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/DataCollection.java > 1531725 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/DataCollectionConverter.java > 1531725 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/protocol/DataCollectionTest.java > 1531725 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java > 1531725 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java > 1531725 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java > 1531725 > > Diff: https://reviews.apache.org/r/14629/diff/ > > > Testing > ------- > > Unit tests pass. > > > Thanks, > > Stanton Sievers > >
