> On Oct. 17, 2013, 12:09 p.m., Ryan Baxter wrote: > > Do we really want to not cache all of the REST API requests? I imagine > > there is some data that is OK to cache. Which APIs specifically are > > returning you outdated information? > > Andreas Kohn wrote: > As to the specific APIs: unfortunately I cannot recall that, I'm at the > moment cleaning up a patched shindig (3.0.0-beta3) in a system I inherited, > and much of that information is lost. > > I've been thinking about that question though, and I think the safe > default is to not cache anything. There are no proper ways (that I can see at > the moment) to have the lower layers of shindig convey to the servlet that > data has changed, and that it should force an update (ETag change, > If-Modified-Since, etc). > >
I think we need to be more specific about when we want to cache and when we do not want to cache things. There are always going to be requests that return data that are unlikely to change ever which we would like to cache. If you can figure out which requests you were having problems with we can work on a better solution. - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14712/#review27120 ----------------------------------------------------------- On Oct. 17, 2013, 1:10 p.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14712/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 1:10 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1942 > https://issues.apache.org/jira/browse/SHINDIG-1942 > > > Repository: shindig > > > Description > ------- > > We had an issue with IE showing (sometimes) outdated information. In the end > it seems we're hit by some caching issue in IE, as described here: > http://thinking-in-code.blogspot.com/2010/06/preventing-internet-explorer-from.html > > Please note: patch was created against 3.0.0-beta3, but should apply to > 2.5.0-updateX as well. > > > Diffs > ----- > > > tags/shindig-project-3.0.0-beta3/java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java > 1532688 > > tags/shindig-project-3.0.0-beta3/java/common/src/test/java/org/apache/shindig/protocol/DataServiceServletTest.java > 1532688 > > Diff: https://reviews.apache.org/r/14712/diff/ > > > Testing > ------- > > See unit test in patch. > > Issue was observed in our production environment, and was fixed by the patch. > > > Thanks, > > Andreas Kohn > >
