> On Nov. 11, 2013, 12:44 p.m., Stanton Sievers wrote: > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImpl.java, > > line 69 > > <https://reviews.apache.org/r/15413/diff/2/?file=381926#file381926line69> > > > > Were you able to overcome the issue outlined in this TODO? > > Andreas Kohn wrote: > In "production" mode the constants are bound by common/PropertiesModule. > It's indeed a bit odd that there they get bound to a String instance, but > from what I can see this still worked. I've checked our configuration loader, > and compared to Shindig's 'PropertiesModule' the only change we have is to > read both 'shindig.properties' and then our properties into a single > j.u.Properties instance, and then call > Names.bindProperties(binder(), mergedProperties); > > I have not explicitly tried starting the sample container app, but will > do that and check that they get loaded properly there as well. I've added a > more explicit test for this to the patch, and changed the > SocialApiTestsGuiceModule to bind the constants as Strings as well. >
Tried: 1. Build shindig (without any patches except this one) 2. cp java/server/target/shindig-server-2.5.1-SNAPSHOT.war into Apache Tomcat 7.0.47[*] 3. Start and check that adding things works as expected, without errors in the logs. [*] The installation instructions at http://shindig.apache.org/download.html need a bit of love: the demo only works if the .war is at the *root* context, otherwise gadget adding/removing just does nothing except logging javascript errors. :) - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15413/#review28648 ----------------------------------------------------------- On Nov. 11, 2013, 2:34 p.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15413/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2013, 2:34 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1949 > https://issues.apache.org/jira/browse/SHINDIG-1949 > > > Repository: shindig > > > Description > ------- > > Inject shindig.oauth2.authCodeExpiration, > shindig.oauth2.accessTokenExpiration and > shindig.oauth2.refreshTokenExpiration. > > Note that shindig.oauth2.refreshTokenExpiration is already bound in the test > module, but not yet used in the Oauth2ServiceImpl. > > > Diffs > ----- > > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImpl.java > 1540645 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java > 1540645 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/core/oauth2/OAuth2ServiceImplTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15413/diff/ > > > Testing > ------- > > Unit tests still pass. > > > Thanks, > > Andreas Kohn > >
