----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15405/ -----------------------------------------------------------
(Updated Nov. 19, 2013, 10:46 a.m.) Review request for shindig. Changes ------- Rebase patch to r1543354. Applies cleanly on linux, previously there was some fuzz needed. [andreas@winterfell shindig-upstream]$ patch -p0< SHINDIG-1947-bridge-methods.diff patching file java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanJsonConverter.java patching file java/common/src/test/java/org/apache/shindig/protocol/conversion/BeanJsonConverterTest.java Bugs: SHINDIG-1947 https://issues.apache.org/jira/browse/SHINDIG-1947 Repository: shindig Description ------- Ignore bridge methods when searching for property setters. Those methods are added by the java compiler, and there will always be a "correctly typed" setter method. See http://stas-blogspot.blogspot.nl/2010/03/java-bridge-methods-explained.html for details on bridge methods. Diffs (updated) ----- trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanJsonConverter.java 1543354 trunk/java/common/src/test/java/org/apache/shindig/protocol/conversion/BeanJsonConverterTest.java 1543354 Diff: https://reviews.apache.org/r/15405/diff/ Testing ------- Unit test in patch, and patch itself is used in our app that uses generic mix-in interfaces to control extension fields for opensocial objects. Thanks, Andreas Kohn