-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15420/
-----------------------------------------------------------

(Updated Dec. 3, 2013, 12:09 p.m.)


Review request for shindig.


Changes
-------

Update diff to only contain API changes, and make it dependent on #15960 / 
SHINDIG-1960 for the functional fixes.


Bugs: SHINDIG-1951
    https://issues.apache.org/jira/browse/SHINDIG-1951


Repository: shindig


Description (updated)
-------

Change API of MessageService#createMessage() to return the id of the message 
(as defined in 
http://opensocial.github.io/spec/2.5.1/Social-API-Server.xml#rfc.section.2.7.2),
 and implement this behavior in JsonDbOpensocialService.


Diffs (updated)
-----

  
trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/MessageService.java
 1547331 
  
trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
 1547331 
  
trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/MessageHandlerTest.java
 1547331 
  
trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java
 1547331 

Diff: https://reviews.apache.org/r/15420/diff/


Testing
-------

* Unit test
* Curl usage: 
  1. curl -D - -X POST -H Content-Type:application/json --data-binary 
'{recipients:["jane.doe"],title:"Message",body:"Body",type:"email"}' 
http://localhost:8080/social/rest/messages/john.doe/publicMessage
  2. curl -D - -X GET -H Content-type:application/json 
http://localhost:8080/social/rest/messages/jane.doe/publicMessage/(returned id 
from step 1)


Thanks,

Andreas Kohn

Reply via email to