-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16401/
-----------------------------------------------------------
(Updated Dec. 19, 2013, 9:08 p.m.)
Review request for shindig.
Changes
-------
Fixed spacing
Bugs: SHINDIG-1963
https://issues.apache.org/jira/browse/SHINDIG-1963
Repository: shindig
Description
-------
There is logic in TokenAuthorizationResponseHandler that looks at the content
type of the auth response and tried to get the access token and other
properties from the response based on the response type. The logic was
specific to certain providers, ie Google uses one content type, Facebook uses
another. I ran into a problem today where the GitHub provider used a different
content type but essentially was the same as Facebook. To simplify things I
think we should default to handling the response as
application/x-www-form-urlencoded unless they specify a different content type
that we know how to handle (right now that is application/json).
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenAuthorizationResponseHandler.java
1550185
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/TokenAuthorizationResponseHandlerTest.java
1550185
Diff: https://reviews.apache.org/r/16401/diff/
Testing
-------
Updated unit tests and tested gadget with Google and GitHub providers
Thanks,
Ryan Baxter
