----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18430/#review35303 -----------------------------------------------------------
Ship it! Ship It! - Stanton Sievers On Feb. 24, 2014, 5:10 p.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18430/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 5:10 p.m.) > > > Review request for shindig. > > > Repository: shindig > > > Description > ------- > > authorize.jsp uses PageContext from jsp-api, so declare that in the pom to > unbreak validation in Eclipse. > > This is otherwise non-functional: the container should provide the > javax.servlet.jsp package, so at runtime all is fine (or is not, in the case > of some jetty 7 versions which do not have it, but the commit doesn't intend > to fix that). > > > Diffs > ----- > > /trunk/pom.xml 1571342 > > Diff: https://reviews.apache.org/r/18430/diff/ > > > Testing > ------- > > Eclipse doesn't complain about validation errors in authorize.jsp. > > > Thanks, > > Andreas Kohn > >
