----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18431/#review35403 -----------------------------------------------------------
Ship it! Ship It! - Ryan Baxter On Feb. 24, 2014, 5:28 p.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18431/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 5:28 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1967 > https://issues.apache.org/jira/browse/SHINDIG-1967 > > > Repository: shindig > > > Description > ------- > > Adjust the names of the parameters used in the mediaItems to match with > OpenSocial, while retaining compatibility with previous versions. > > > Diffs > ----- > > > /trunk/java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java > 1571342 > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MediaItemHandler.java > 1571342 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/MediaItemHandlerTest.java > 1571342 > > Diff: https://reviews.apache.org/r/18431/diff/ > > > Testing > ------- > > * Some unit tests for the backwards-compatible part in the patch > * RPC and non-RPC calls in our production environment using this patch: > before the patch the requests failed (missing parameters), afterwards they > worked. > > > Thanks, > > Andreas Kohn > >
