----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19572/#review38259 -----------------------------------------------------------
Ship it! Ship It! - Chris Geer On March 23, 2014, 9:34 p.m., Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19572/ > ----------------------------------------------------------- > > (Updated March 23, 2014, 9:34 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1970 > https://issues.apache.org/jira/browse/SHINDIG-1970 > > > Repository: shindig > > > Description > ------- > > There may be some scenarios where you want to enable scrolling on the iFrame > generated by the container since the content of the iFrame and CSS is out of > the control of the container [1]. > > [1] > http://mail-archives.apache.org/mod_mbox/shindig-users/201402.mbox/%3C021a01cf29bd%24ffadc610%24ff095230%24%40com%3E > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site_holder.js > 1580608 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js > 1580608 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js > 1580608 > > Diff: https://reviews.apache.org/r/19572/diff/ > > > Testing > ------- > > Added unit test > > > Thanks, > > Ryan Baxter > >
