> On May 27, 2015, 7:43 p.m., Doug Davies wrote: > > Added another patch that tries to re-use the previous moduleId off the > > cached token. It also checks if mid is defined (as suggested by Ryan). > > Ryan Baxter wrote: > Looks good Doug, is there any kind of unit tests we can add around this? > > Doug Davies wrote: > I'll see if I can add a js test
Hmmmmm... js tests are hard. :) I played with this most of today and was unsuccessful. Do we have to have a test for this change to be accepted (other than the sample I showed)? - Doug ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34673/#review85425 ----------------------------------------------------------- On May 27, 2015, 7:39 p.m., Doug Davies wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34673/ > ----------------------------------------------------------- > > (Updated May 27, 2015, 7:39 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1995 > https://issues.apache.org/jira/browse/SHINDIG-1995 > > > Repository: shindig > > > Description > ------- > > GadgetSite setModuleId_ only sets the module id if rendering the first time > > > Diffs > ----- > > > trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js > 1681771 > > Diff: https://reviews.apache.org/r/34673/diff/ > > > Testing > ------- > > See bug (SHINDIG-1995) for details on how to test this. > > > Thanks, > > Doug Davies > >
