I took a look and other than minor pom modifications, there are no technical problems moving this to trunk. However, I do have a few philosophical remarks to make. First of all, Crowd is not from Apache and it is not Apache licensed. We do have other support modules that are non-Apache projects but they are all Apache licensed. Apache's license obviously allows you to integrate with anything but Apache projects shouldn't create hard dependencies to non-Apache licensed code. As an optional support module a Crowd realm is fine but then why would we need to build it every time with the rest of it. On the other hand, this could probably be useful for quite a few people and I'm fundamentally against keeping perfectly working code in sandbox - it'll be just ignored and probably left unmaintained in the long run.
Intuitively, I'd do two things: create a new shiro-parent pom module and make this module a new separately releasable shiro-support-crowd module that would live right under the trunk. To really do this properly, it'd ultimately mean that we'd have to shift shiro-root and all of its sub-modules down under its own shiro-root directory and the trunk would simply contain separately releasable modules (Take a look at Tynamo's module organization as an example: http://svn.codehaus.org/tynamo/trunk/ - this is strictly according to the Maven/svn best practices). Not sure it'd be worth it though - we are talking about two classes here. What say you? Practical solution is to wait till 1.1.0 is released, then re-organize as suggested (it's really not that bad) and bring Crowd in under the trunk. Kalle On Sat, Oct 16, 2010 at 9:56 AM, Alan D. Cabrera <[email protected]> wrote: > I've finally got off my behind and finished the realm. It's in the sandbox > waiting your approval to merge into trunk. > > > Regards, > Alan > >
