[ 
https://issues.apache.org/jira/browse/SHIRO-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971755#action_12971755
 ] 

Les Hazlewood commented on SHIRO-226:
-------------------------------------

Hi Janne,

This is good - thanks very much for the patch!

Before we resolve this issue though, I think the default 
SimplePrincipalCollection should contain this logic as well - there are times 
when principals are serialized outside the context of 'rememberMe' (e.g when 
caching), and those usages should benefit from this as well.

Also, this would further reduce the need for users to manually specify the 
SimplePrincipalSerializer, since the size savings between it and the default 
serialization approach should be very small (the difference being the number of 
bytes taken up by the MAGIC constant vs the class name included by the JDK).

I'll implement those changes in SimplePrincipalCollection, create some more 
tests for it, and update this issue when I'm done.

> Default rememberMe cookie size is rather large
> ----------------------------------------------
>
>                 Key: SHIRO-226
>                 URL: https://issues.apache.org/jira/browse/SHIRO-226
>             Project: Shiro
>          Issue Type: Improvement
>          Components: RememberMe
>    Affects Versions: 1.1.0
>            Reporter: Janne Jalkanen
>         Attachments: SHIRO-226-jalkanen-1.patch
>
>
> The rememberMe cookie size is fairly big since it uses the DefaultSerializer, 
> which serializes a lot of stuff which is not really necessary - especially 
> for the fairly common single realm - single principal case. Please see 
> discussion at 
> http://mail-archives.apache.org/mod_mbox/shiro-user/201012.mbox/%[email protected]%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to