[ 
https://issues.apache.org/jira/browse/SHIRO-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981441#action_12981441
 ] 

Les Hazlewood commented on SHIRO-233:
-------------------------------------

Upon looking at this further, I don't feel that the Authenticator
interface should be changed - supporting listeners is an additional
feature IMO.  That is, just because an Authenticator exists, it
doesn't necessarily mean that listeners can be supported (depending on
the environment).

I believe we instead need to make an AuthenticationListenerRegistrar
interface and that should have the add/remove methods and the default
Authenticator implementation(s) should implement the
AuthenticationListenerRegistrar interface.  This achieves the same
result and is a little 'cleaner' IMO.

Any objections?

Les




> Add addAuthenticationListener() and removeAuthenticationListener() operations 
> to Authenticator interface
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SHIRO-233
>                 URL: https://issues.apache.org/jira/browse/SHIRO-233
>             Project: Shiro
>          Issue Type: Improvement
>          Components: Specification API
>    Affects Versions: 0.9, 1.0.0, 1.1.0
>            Reporter: Kalle Korhonen
>            Assignee: Kalle Korhonen
>             Fix For: 1.2.0
>
>
> Funny as it is, though we have AuthenticationListener interface, we don't 
> have a way of adding or removing these listeners in the API (you can access 
> AbstractAuthenticator's listener collection if your Authenticator extends it).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to