Today I was going through Shiro Tutorial. And small thing attracted my 
attention in logging output at DEBUG level.  I've downloaded sources and fix 
it. Here is the patch against current trunk

Index: src/main/java/org/apache/shiro/mgt/DefaultSecurityManager.java
===================================================================
--- src/main/java/org/apache/shiro/mgt/DefaultSecurityManager.java      
(revision 1291058)
+++ src/main/java/org/apache/shiro/mgt/DefaultSecurityManager.java      
(working copy)
@@ -547,7 +547,7 @@
         PrincipalCollection principals = subject.getPrincipals();
         if (principals != null && !principals.isEmpty()) {
             if (log.isDebugEnabled()) {
-                log.debug("Logging out subject with primary principal {}" + 
principals.getPrimaryPrincipal());
+                log.debug("Logging out subject with primary principal {}", 
principals.getPrimaryPrincipal());
             }
             Authenticator authc = getAuthenticator();
             if (authc instanceof LogoutAware) {

It's not important anyway, just to make things look nicer ;)

Best regards,
Mike Golod



Reply via email to