This seems the most logical approach to me - I just wanted to make sure that we do it in a clean enough way that we can make it work across environments.
On Mon, May 21, 2012 at 3:56 PM, Jared Bunting <[email protected]> wrote: > I'm thinking that the registration will be done separately for each > injection environment. Both Spring and Guice expose some sort of > instantiation listener so it makes sense to me to use those mechanisms. > The Guice one should be pretty straightforward, but it's been so long > since I've worked with Spring, I'll have to do some reading on that one. > > -Jared > > On Mon 21 May 2012 04:12:17 PM CDT, Les Hazlewood wrote: >> That makes sense to me. What about Spring/Guice environments? Would >> they use this same mechanism or potentially something different? >> >> -- >> Les Hazlewood >> CTO, Stormpath | http://stormpath.com | 888.391.5282 >> twitter: @lhazlewood | http://twitter.com/lhazlewood >> blog: http://leshazlewood.com >> stormpath blog: http://www.stormpath.com/blog >> >> >> On Mon, May 21, 2012 at 1:06 PM, Jared Bunting >> <[email protected]> wrote: >>> I think that is probably how I am going to go about this. My only >>> thought is that I may want to add some sort of "instantiation listener" >>> to the ini factories that can be called by shiro-jmx to register an >>> MBean whenever it sees an object instantiated that should have one. >>> >>> Thoughts? >>> >>> -Jared >>> >>> On Mon 21 May 2012 01:01:41 PM CDT, Les Hazlewood wrote: >>>> I love this idea. Could you contribute it as a new support module? >>>> e.g. shiro-jmx? >>>> >>>> Looking forward to seeing it! >>>> >>>> Best, >>>> >>>> -- >>>> Les Hazlewood >>>> CTO, Stormpath | http://stormpath.com | 888.391.5282 >>>> twitter: @lhazlewood | http://twitter.com/lhazlewood >>>> blog: http://leshazlewood.com >>>> stormpath blog: http://www.stormpath.com/blog >>>> >>>> >>>> On Sat, May 19, 2012 at 11:58 PM, jleleu <[email protected]> wrote: >>>>> Hi Jared, >>>>> >>>>> It's a good idea to add JMX support to Shiro as it's always nice to have >>>>> MBeans to monitor an application. >>>>> What you propose seems to be pretty complete and sufficient. >>>>> >>>>> Nonetheless, I think that you could add some information about performance >>>>> (to see what is really used and where time is consumed in the >>>>> application) : >>>>> - counters on calls (filters, realms, ...) >>>>> - counters on reads / writes (session...) >>>>> - time spent in different parts (filters, realms, ...) >>>>> >>>>> Best regards, >>>>> Jérôme >>>>> >>>>> >>>>> -- >>>>> View this message in context: >>>>> http://shiro-developer.582600.n2.nabble.com/JMX-Support-tp7566899p7567612.html >>>>> Sent from the Shiro Developer mailing list archive at Nabble.com. >>> >>> > >
