[ 
https://issues.apache.org/jira/browse/SHIRO-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543090#comment-13543090
 ] 

Jared Bunting commented on SHIRO-389:
-------------------------------------

The say you describe this makes sense to me.  However, I think there's a deeper 
issue here.  shiro-core cannot possibly know about every bundle that may be 
referenced in shiro.ini - the very nature of shiro.ini is that you can specify 
ANY class.  In addition, I think that Les's holdup is that adding shiro-ehcache 
as an osgi dependency of shiro-core essentially introduces a circular 
dependency issue - shiro-ehcache has to know about shiro-core (for compile 
time) and shiro-core has to know about shiro-ehcache (explicitly in osgi 
configuration).

My knowledge of OSGI is limited primarily to what I've read, and my practical 
experience is limited to a few tutorials.  However, this seems like a situation 
where using fragments would make sense.  My understanding of fragments is that 
shiro-ehcache would declare it's "Fragment-Host" as shiro-core, and then 
shiro-ehcache's classes would be available on shiro-core's classpath without 
having to modify shiro-core.  The upside of this is that it would work for any 
thirdparty extension as well - say a jcache implementation, or an internal 
corporate Realm implementation.

Thoughts?
                
> Fix OSGI Exports for shiro-ehcache
> ----------------------------------
>
>                 Key: SHIRO-389
>                 URL: https://issues.apache.org/jira/browse/SHIRO-389
>             Project: Shiro
>          Issue Type: Bug
>          Components: Caching 
>    Affects Versions: 1.2.0, 1.2.1
>            Reporter: Chris Geer
>            Assignee: Les Hazlewood
>             Fix For: 1.2.2, 1.3.0
>
>         Attachments: SHIRO_389_core.patch, SHIRO-389.patch
>
>
> Currently the osgi-export in the pom file is org.apache.shiro.ehcache which 
> isn't a valid package. It should be changed to org.apache.shiro.cache.ehcache

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to