On Tue, Jul 7, 2015 at 3:46 PM, Bryan Turner <[email protected]> wrote:
> As long as the source and target flags are set right, it shouldn't matter > what Java version you use to actually perform the build--the emitted > bytecode should still be compatible with Java 6. (Shiro's source and target > flags are currently set for Java 5, in fact, which further reinforces this.) > Doesn't that issue just mean you need to run the build with Java 7 or Java > 8? It doesn't seem like this means you need to drop Java 6 support. Am I > missing something? > Merely setting the target flag is not enough to guarantee the code will run on the the target jre if it was compiled against a newer runtime (non-authoritative, but just as an example see http://stackoverflow.com/questions/3638399/maven-release-plugin-specify-java-compiler-version). Specifically in the case of Shiro it may work but the simplest, safest way to make sure it runs on the target jre is to compile with the corresponding jdk. Kalle > Best regards,Bryan Turner > > Date: Tue, 7 Jul 2015 14:18:43 -0700 > > Subject: Re: About to make a 1.2.4 release > > From: [email protected] > > To: [email protected] > > > > Yes, releasing of course everything that's committed in 1.2.x since the > > last release. The tag's done ( > > http://svn.apache.org/repos/asf/shiro/tags/shiro-root-1.2.4/) but since > > nothing is ever that easy, I run head first into an issue with the > required > > TLS key length on repository.apache.org ("Could not generate DH keypair: > > Prime size must be multiple of 64, and can only range from 512 to 1024", > > see https://issues.apache.org/jira/browse/BUILDS-85). The git of it is > that > > the repository won't accept a connection made from JRE 1.6 JVM ( > > http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6521495). As a > test, I > > manually ran the deployment using a 1.7 JDK and that succeeded ( > > https://repository.apache.org/content/repositories/orgapacheshiro-1008). > > > > There are basically two choices we can make: > > 1) Just accept that it won't work on JDK 1.6 and bump the requirement to > > JRE 1.7 for 1.2.4. Apache is really about making source releases and > > binaries are for convenience only but then again, I don't know how well > > this kind of change would go with semver. > > 2) Drop the current staged repo and try to hack the build so I can first > > compile in JDK 1.6 and then only deploy using JDK 1.7 but skip over > compile > > and install (I generally know my way around Maven but I'm really not sure > > if that's even possible). > > > > The problem is rather artificial since the code itself compiles fine in > JDK > > 1.6. WDYT, any other suggestions? > > > > Kalle > > > > On Tue, Jul 7, 2015 at 7:15 AM, Brian Demers <[email protected]> > wrote: > > > > > Yup, that one was already in the 1.2.x branch. > > > > > > On Tue, Jul 7, 2015 at 4:16 AM, jleleu <[email protected]> wrote: > > > > > > > Hi, > > > > > > > > This security patch: https://issues.apache.org/jira/browse/SHIRO-518 > > > will > > > > go into the 1.2.4 release, won't it? > > > > > > > > Thanks. > > > > Best regards, > > > > Jérome > > > > > > > > > > > > 2015-07-06 23:51 GMT+02:00 kaosko [via Shiro Developer] < > > > > [email protected]>: > > > > > > > > > Hey, I'm planning on making 1.2.4 release to make the bug fix for > > > > > https://issues.apache.org/jira/browse/SHIRO-498 available > (frankly, I > > > > > find > > > > > it perplexing that more people haven't complained about it). The > dryRun > > > > > succeeds, so this mostly serves as a heads up for the upcoming > vote. > > > > > > > > > > Kalle > > > > > > > > > > > > > > > ------------------------------ > > > > > If you reply to this email, your message will be added to the > > > discussion > > > > > below: > > > > > > > > > > > > > > > > > > http://shiro-developer.582600.n2.nabble.com/About-to-make-a-1-2-4-release-tp7578633.html > > > > > To start a new topic under Shiro Developer, email > > > > > [email protected] > > > > > To unsubscribe from Shiro Developer, click here > > > > > < > > > > > > > > http://shiro-developer.582600.n2.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=582600&code=bGVsZXVqQGdtYWlsLmNvbXw1ODI2MDB8LTExNzY2MzcxMTY= > > > > > > > > > > . > > > > > NAML > > > > > < > > > > > > > > http://shiro-developer.582600.n2.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > View this message in context: > > > > > > > > http://shiro-developer.582600.n2.nabble.com/About-to-make-a-1-2-4-release-tp7578633p7578634.html > > > > Sent from the Shiro Developer mailing list archive at Nabble.com. > > > > > > > > >
