yes, that's pretty much the case. You also can't manually close PRs, but if you do a git merge rather than rebase of the commits, then the P will be auto-closed once you push the change.
On 5 August 2015 at 15:19, jleleu <[email protected]> wrote: > Hi, > > So the only difference / limitation when using github.com for an Apache > project is that I cannot click on the "Merge pull request", but everythings > can work the same (sending a PR, commenting...) > > Thanks. > Best regards, > Jérôme > > > 2015-08-05 12:53 GMT+02:00 Dan Haywood [via Shiro Developer] < > [email protected]>: > > > Just to chip in .... > > > > Over on Apache Isis (we integrate with Shiro) we use ASF's git, mirrored > > to > > github; it's perfectly possible to apply github PRs, see [1] and [2] > > > > The script was adapted from one that the Apache Wicket committers use, > who > > do something similar. > > > > HTH > > Dan > > > > [1] > > > http://isis.apache.org/guides/cg.html#_cg_committers_merging-a-pull-request > > [2] https://github.com/apache/isis/blob/master/github-pr.sh > > > > > > On 5 August 2015 at 11:44, jleleu <[hidden email] > > <http:///user/SendEmail.jtp?type=node&node=7578729&i=0>> wrote: > > > > > Hi, > > > > > > I admit branching and merging is easier with git, but still using > > patches > > > to > > > submit source codes makes contributions harder. > > > Everyday, I use github.com (for CAS and pac4j) and people can fork the > > > projects and contribute by sending pull requests on which you can > > discuss / > > > make evolve the changes before merging. That's really comfortable. > > > > > > Best regards, > > > Jérôme > > > > > > > > > > > > > > > -- > > > View this message in context: > > > > > > http://shiro-developer.582600.n2.nabble.com/Migration-to-Git-tp7578693p7578728.html > > > Sent from the Shiro Developer mailing list archive at Nabble.com. > > > > > > > > > ------------------------------ > > If you reply to this email, your message will be added to the discussion > > below: > > > > > http://shiro-developer.582600.n2.nabble.com/Migration-to-Git-tp7578693p7578729.html > > To start a new topic under Shiro Developer, email > > [email protected] > > To unsubscribe from Shiro Developer, click here > > < > http://shiro-developer.582600.n2.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=582600&code=bGVsZXVqQGdtYWlsLmNvbXw1ODI2MDB8LTExNzY2MzcxMTY= > > > > . > > NAML > > < > http://shiro-developer.582600.n2.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml > > > > > > > > > -- > View this message in context: > http://shiro-developer.582600.n2.nabble.com/Migration-to-Git-tp7578693p7578732.html > Sent from the Shiro Developer mailing list archive at Nabble.com. >
